-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failure JIT/superpmi/superpmicollect/superpmicollect.sh #83320
Comments
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsFailed in Run: runtime-coreclr outerloop 20230312.2 Failed tests:
Error message:
Stack trace:
More failures
|
It looks like the failures are only on Alpine. The "ERROR: program /usr/bin/perl not found" is probably coming because the test invokes perl:
Maybe Alpine no longer has perl? Or maybe we just started running this test on Alpine? |
Alpine images were just updated: #82931 |
Maybe the change that actually caused perl to be removed from the Alpine images was dotnet/dotnet-buildtools-prereqs-docker#818? |
The perl use here is just normalizing the newlines, can it be replaced by some simple C# code to accomplish the same? |
We can bring Perl back. I tried to keep the image minimal bu we can certainly bring more. As @jakobbotsch said, we can perhaps fix it in different ways - perhaps in stages. Either via shell script, c# or Pythin (that is needed anyway for Helix) |
I'll look into alternatives, either C# or Python.
Possibly not. We used to build the wrapper scripts on Windows (even the .sh ones) and copy them to Linux/Mac for running, where they would need CR/LF->LF munging before running. Not sure if that's still required. |
`perl` was removed from the Alpine images we use. The superpmi unit test harness was using `perl` to convert the line endings in the superpmicollect.sh wrapper script harness from Windows CR/LF format to Linux/Mac LF format. It appears this is no longer necessary, as the wrapper scripts appear to be built in CI during the "Generate tests wrappers" step on Linux when they will be run on Linux, so they already have the correct line endings. Remove the call to invoke `perl`. Fixes dotnet#83320
`perl` was removed from the Alpine images we use. The superpmi unit test harness was using `perl` to convert the line endings in the superpmicollect.sh wrapper script harness from Windows CR/LF format to Linux/Mac LF format. It appears this is no longer necessary, as the wrapper scripts appear to be built in CI during the "Generate tests wrappers" step on Linux when they will be run on Linux, so they already have the correct line endings. Remove the call to invoke `perl`. Fixes #83320
Failed in Run: runtime-coreclr outerloop 20230312.2
Failed tests:
Error message:
Stack trace:
More failures
The text was updated successfully, but these errors were encountered: