-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FreeBSD-specific logic to pal::get_default_installation_dir_for_arch #100731
Conversation
@dotnet-policy-service agree |
LGTM As an aside: |
On FreeBSD the |
Fair point. That file would not make sense for a FreeBSD port. oooh! That differential also has a working powershell port from "zirias" which means I can close out 3 upstream PRs for getting FreeBSD added to the 3 powershell repos. Happy to see someone get that over the finish line |
@arrowd LGTM. IIRC setting |
Looking at this and according to hier(7), |
6301bed
to
d0bd7c7
Compare
Bump. Can we get this in? |
@elinor-fung for review |
Apologies for the delay. Thanks, @arrowd! |
The full problem context: https://reviews.freebsd.org/D44560
This change tries to address it for the native FreeBSD case. The Linuxulator case can hopefully be fixed by installing
/compat/linux/etc/dotnet/install_location
.@sec @Thefrank can you look into this?