Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][debugger] Fix inspect gchandle #102637

Merged
merged 1 commit into from
May 28, 2024

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented May 23, 2024

We are not sending IntPtr as ValueType anymore because it was causing an infinity recursion because IntPtr has a field pointing to itself. So we need support receiving the IntPtr as I8.

Without the PR:
New Debugger Engine:
image
Old Debugger Engine:
image

With the PR:
New Debugger Engine:
image
Old Debugger Engine:
image

Copy link
Contributor

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any chance we need to handle I4 here too for 32 bit runtimes?

@thaystg
Copy link
Member Author

thaystg commented May 24, 2024

Is there any chance we need to handle I4 here too for 32 bit runtimes?

I don't think so, we are always sending it as a long value:

buffer_add_byte (buf, MONO_TYPE_PTR);

Also every PTR we always send as a long value:

gssize val = *(gssize*)addr;

@thaystg
Copy link
Member Author

thaystg commented May 28, 2024

Can I get a review?

@lewing lewing merged commit 0005249 into dotnet:main May 28, 2024
79 checks passed
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants