-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace use of target dependent TestZ
intrinsic
#104488
Conversation
d58b185
to
05211ad
Compare
TestZ
intrinsicTestZ
intrinsic
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Utility.cs
Outdated
Show resolved
Hide resolved
Depends on #102705. |
@tannergooding There are unexpected regressions, see MihuBot/runtime-utils#501
|
That particular case should be mostly resolved with #104517, There's more improvements that could be had as well, but its a step in the right direction overall |
It's not really a regression per say and in other cases could be an optimization. Either way, it shouldn't be impactful to this PR, I'll just finish the remaining work here and not fold in the case the |
|
I wouldn't say this depends on #10944, I think it's fine to take as is. If you could mark it |
@tannergooding I've suggested we make the suggested changes in a follow-up PR. |
* Replace uses of `TestZ` intrinsic * remove pragma warning disable IntrinsicsInSystemPrivateCoreLibConditionParsing * refactor control flow --------- Co-authored-by: Tanner Gooding <[email protected]>
Contributes to #101251.