Fix WinHttp StreamingTest backward compat Version #104722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liveans
added
NO-MERGE
|
Tagging subscribers to this area: @dotnet/ncl |
This was referenced Jul 11, 2024
Open
liveans
force-pushed
the
investigate_103754
branch
from
91ced62 to
8755d42
Compare
liveans
changed the title
liveans
removed
NO-MERGE
This was referenced Jul 12, 2024
liveans
commented
Jul 12, 2024
src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/BidirectionStreamingTest.cs
Outdated
Show resolved
Hide resolved
liveans
commented
Jul 12, 2024
src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/BidirectionStreamingTest.cs
Outdated
Show resolved
Hide resolved
|
/azp run runtime-libraries-coreclr outerloop-windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This is ready for review, but I will wait until winhttp folks confirms the version over email, only after than that I'll merge this. |
liveans
force-pushed
the
investigate_103754
branch
from
164528d to
202690d
Compare
rzikm
approved these changes
Jul 12, 2024
src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/BidirectionStreamingTest.cs
Outdated
Show resolved
Hide resolved
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/9914519934 |
|
@liveans backporting to release/8.0-staging failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Add WS2022 to OsSupport check for Bidirectional Streaming
Applying: Enable the disabled test
error: sha1 information is lacking or useless (src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/BidirectionStreamingTest.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 Enable the disabled test
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@liveans an error occurred while backporting to release/8.0-staging, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
This was referenced Jul 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103754
Server 2022 WinHttp supports the automatic chunking in HTTP/2 now, so our requests are going as
HTTP/2requests instead of falling back to HTTP/1.1.OSVersion doesn't report revision (reports it as 0) and build version will be 20348 for WS2022.