-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Process LinkerArg for wasm targets #107194
Conversation
|
I was working off the assumption that the use of CustomLinkerArg in wit-bindgen was correct, should that be changed to LinkerArg? |
Yes. |
It looks like only iOS consumes LinkerArgs right now @maraf can you take a look across the platforms? |
The |
Tagging subscribers to 'arch-wasm': @lewing |
I just meant I missed the android use in a quick scan, thanks for the full reply. This patch just sticks it in wasi targets, it should really be in the shared bits or at least added to both. |
d0cfce7
to
359aa28
Compare
359aa28
to
94ef07a
Compare
Putting this up for discussion rather than a final form, I think it makes sense to use common names