Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RISC-V] Fix test build failure #107274

Merged
merged 1 commit into from
Sep 3, 2024
Merged

[RISC-V] Fix test build failure #107274

merged 1 commit into from
Sep 3, 2024

Conversation

clamp03
Copy link
Member

@clamp03 clamp03 commented Sep 3, 2024

Fix NETSDK1203: Ahead-of-time compilation is not supported for the target runtime identifier 'linux-riscv64'. [/runtime/src/tests/Common/XUnitLogChecker/XUnitLogChecker.csproj]

Part of #84834
cc @dotnet/samsung

@clamp03
[RISC-V] Disable PublishAot for RISC-V
f9de477 
Fix NETSDK1203: Ahead-of-time compilation is not supported
for the target runtime identifier 'linux-riscv64'.
[/runtime/src/tests/Common/XUnitLogChecker/XUnitLogChecker.csproj]
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 3, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 3, 2024
@clamp03 clamp03 self-assigned this Sep 3, 2024
@clamp03 clamp03 added the arch-riscv Related to the RISC-V architecture label Sep 3, 2024
@clamp03 clamp03 requested a review from agocke September 3, 2024 05:23
@risc-vv
Copy link

risc-vv commented Sep 3, 2024 •
edited
Loading

RISC-V Release-CLR-QEMU: 9394 / 9412 (99.81%) 
=======================
      passed: 9394
      failed: 3
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9519
 TOTAL tests: 9519
   REAL time: 57min 57s 931ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 564091 / 593424 (95.06%) 
=======================
      passed: 564091
      failed: 325
     skipped: 1574
      killed: 29008
------------------------
  TOTAL libs: 256
 TOTAL tests: 594998
   REAL time: 1h 49min 5s 993ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and links

GIT: f9de4776b526a36798f33b754690f99602611359
CI: 529268ece23d4da7be41ac937cc8f4a2e344e67b
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG
# TESTCLR_RUN
/godata/pipelines/Release-CLR-QEMU/logs/run_tests.log
cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/godata/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 16 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/godata/pipelines/Release-FX-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-FX-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ &&cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing
RISC-V Release-CLR-VF2: 9395 / 9411 (99.83%) 
=======================
      passed: 9395
      failed: 1
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9518
 TOTAL tests: 9518
   REAL time: 2h 56min 33s 404ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 530563 / 577737 (91.83%) 
=======================
      passed: 530563
      failed: 18
     skipped: 1458
      killed: 47156
------------------------
  TOTAL libs: 256
 TOTAL tests: 579195
   REAL time: 2h 40min 50s 329ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and links

GIT: f9de4776b526a36798f33b754690f99602611359
CI: 529268ece23d4da7be41ac937cc8f4a2e344e67b
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 8 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/var/lib/go-agent/pipelines/Release-FX-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-FX-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ &&cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing
RISC-V Release-CLR-VF2: 9396 / 9412 (99.83%) 
=======================
      passed: 9396
      failed: 1
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9519
 TOTAL tests: 9519
   REAL time: 3h 1min 52s 476ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 530563 / 577737 (91.83%) 
=======================
      passed: 530563
      failed: 18
     skipped: 1458
      killed: 47156
------------------------
  TOTAL libs: 256
 TOTAL tests: 579195
   REAL time: 2h 40min 50s 329ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and links

GIT: f9de4776b526a36798f33b754690f99602611359
CI: 529268ece23d4da7be41ac937cc8f4a2e344e67b
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 8 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/var/lib/go-agent/pipelines/Release-FX-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-FX-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ &&cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

@clamp03
Copy link
Member Author

clamp03 commented Sep 3, 2024

@agocke RISCV doesn't support nativeaot yet. I put condition in XUnitLogChecker.csproj. If there is a better way, could you please share? Thank you.

bartlomiejko
bartlomiejko approved these changes Sep 3, 2024
View reviewed changes
Copy link

@bartlomiejko bartlomiejko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clamp03 clamp03 requested review from jkotas and am11 September 3, 2024 08:12
am11
am11 approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@am11 am11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jkotas jkotas merged commit 516e81e into dotnet:main Sep 3, 2024
70 checks passed
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Sep 6, 2024
@clamp03 @radekdoulik
[RISC-V] Disable PublishAot for RISC-V (dotnet#107274)
125af7b 
Fix NETSDK1203: Ahead-of-time compilation is not supported
for the target runtime identifier 'linux-riscv64'.
[/runtime/src/tests/Common/XUnitLogChecker/XUnitLogChecker.csproj]
jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
@clamp03 @jtschuster
[RISC-V] Disable PublishAot for RISC-V (dotnet#107274)
c1279ce 
Fix NETSDK1203: Ahead-of-time compilation is not supported
for the target runtime identifier 'linux-riscv64'.
[/runtime/src/tests/Common/XUnitLogChecker/XUnitLogChecker.csproj]
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
@clamp03 @sirntar
[RISC-V] Disable PublishAot for RISC-V (dotnet#107274)
3c8e3ba 
Fix NETSDK1203: Ahead-of-time compilation is not supported
for the target runtime identifier 'linux-riscv64'.
[/runtime/src/tests/Common/XUnitLogChecker/XUnitLogChecker.csproj]
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bartlomiejko bartlomiejko bartlomiejko approved these changes

@Bajtazar Bajtazar Bajtazar approved these changes

@sirntar sirntar sirntar approved these changes

@gbalykov gbalykov gbalykov approved these changes

@viewizard viewizard viewizard approved these changes

@yurai007 yurai007 yurai007 approved these changes

@jkotas jkotas jkotas approved these changes

@am11 am11 am11 approved these changes

@tomeksowi tomeksowi tomeksowi approved these changes

@agocke agocke Awaiting requested review from agocke

Assignees

@clamp03 clamp03

Labels
arch-riscv Related to the RISC-V architecture community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.