[main] guard agains empty Accept address #108616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/ncl |
This was referenced Oct 7, 2024
stephentoub
reviewed
Oct 8, 2024
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.Unix.cs
Show resolved
Hide resolved
4 tasks
…t/pr-108334-to-main
This was referenced Oct 22, 2024
|
/backport to /release/9.0-staging |
|
Started backporting to /release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/12754845439 |
|
@wfurt an error occurred while backporting to "/release/9.0-staging", please check the run log for details! Error: The specified backport target branch "/release/9.0-staging" wasn't found in the repo. |
|
/backport to release/9.0-staging |
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/12754885863 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108026 and #102663
This is a speculative fix based on feedback from @pepone.
It seems like in some cases accept on macOS does not return valid peer address and we throw on background thread.
This adds some guarding agains that to prevent thread termination.
I don't think workaround from #102663 (comment) is needed.
We already call getpeername if RemoteEndPoint is accessed and remote address is not available. It seems like we do not need it for anything else in CreateAcceptSocket and descendants.