Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Net Stress Tests Improvements 2 #108703

Merged
merged 11 commits into from
Oct 22, 2024

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Oct 9, 2024

Fixes #108551.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 9, 2024
@rzikm
Copy link
Member Author

rzikm commented Oct 9, 2024

/azp run runtime-libraries stress-ssl

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rzikm rzikm added area-System.Net and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 9, 2024
@rzikm rzikm requested a review from antonfirsov October 9, 2024 11:56
@rzikm rzikm changed the title Stress improvements 2 System.Net Stress Tests Improvements 2 Oct 9, 2024
@rzikm rzikm marked this pull request as ready for review October 10, 2024 11:43
@rzikm
Copy link
Member Author

rzikm commented Oct 10, 2024

/azp run runtime-libraries stress-ssl

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov
Copy link
Member

unknown flag: --abort-on-container-exit

Weird, it should be working according to the docs.

Otherwise, the changes look good, but I want to test them locally.

@rzikm
Copy link
Member Author

rzikm commented Oct 10, 2024

Otherwise, the changes look good, but I want to test them locally.

on it, I also found out that passing -n to the script does not work for some stupid reason, so there is more work to be done.

@wfurt
Copy link
Member

wfurt commented Oct 10, 2024

unknown flag: --abort-on-container-exit

Weird, it should be working according to the docs.

Otherwise, the changes look good, but I want to test them locally.

do we know what docker-compose version runs in CI? I had similar problems in the past when using recently added syntax.

@antonfirsov
Copy link
Member

antonfirsov commented Oct 10, 2024

One more thing I just noticed, that there is no dumps share volume mounted in the SslStress docker-compose.yml while all the infra for dump sharing seems to be present, we probably want to fix this too.

While there, I think we can also delete the version: 3 lines, to get rid of the docker compose warning.

@rzikm rzikm force-pushed the stress-improvements-2 branch from 4545fe3 to 03ca742 Compare October 11, 2024 08:27
@rzikm rzikm removed request for maraf and ilonatommy October 11, 2024 08:27
@rzikm
Copy link
Member Author

rzikm commented Oct 11, 2024

/azp run runtime-libraries stress-ssl

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rzikm
Copy link
Member Author

rzikm commented Oct 11, 2024

/azp run runtime-libraries stress-http

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rzikm
Copy link
Member Author

rzikm commented Oct 11, 2024

unknown flag: --abort-on-container-exit

It works when run from WSL2 (because it uses the Docker installed in Windows, but my Ubuntu VM I still have to invoke docker-compose (it does not recognize docker compose at all, version 24.0.7)

@antonfirsov
Copy link
Member

/azp run runtime-libraries stress-ssl

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov
Copy link
Member

/azp run runtime-libraries stress-ssl

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Doing a final run, just in case, then :shipit:

@antonfirsov antonfirsov merged commit 1f40b0d into dotnet:main Oct 22, 2024
82 of 86 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HttpStress] [SslStress] Not possbile to run locally with docker
3 participants