Synthesize assembly names by default for ilproj-based tests #108997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
|
/azp run runtime-coreclr crossgen2 outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Oct 18, 2024
|
/azp run runtime-coreclr crossgen2 outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lambdageek
added
test-enhancement
|
Tagging subscribers to this area: @JulieLeeMSFT |
This was referenced Oct 18, 2024
kg
force-pushed
the
ilproj-composite-test-fix-2
branch
2 times, most recently
from
42ca8ff to
7392372
Compare
|
/azp run runtime-coreclr crossgen2 outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkoritzinsky
approved these changes
Oct 23, 2024
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
…08997) * Synthesize ilasm assembly names by default for all IL tests * Fix diamondshape tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the number of test failures I get locally on a full run from 73 to 10, which should get the crossgen outerloop closer to green.
Background: We have a huge number of tests in .il form and many of them have
.assemblydirectives with incorrect assembly names. In many cases this isn't a problem, but for crossgen it makes it impossible to locate the assembly pointed to by a reference because the filename won't match.