-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API Implementation]: Expose CookieException constructors #109026
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note regarding the
|
1 similar comment
Note regarding the
|
dotnet-policy-service
bot
added
the
community-contribution
Indicates that the PR has been added by a community member
label
Oct 18, 2024
campersau
reviewed
Oct 18, 2024
src/libraries/System.Net.Primitives/tests/UnitTests/CookieExceptionTest.cs
Show resolved
Hide resolved
MihaZupan
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
src/libraries/System.Net.Primitives/src/System/Net/CookieException.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Primitives/src/System/Net/CookieException.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Primitives/src/System/Net/CookieException.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Primitives/tests/UnitTests/CookieExceptionTest.cs
Show resolved
Hide resolved
This was referenced Oct 18, 2024
Co-Authored-By: Miha Zupan <[email protected]>
antonfirsov
approved these changes
Oct 21, 2024
3 tasks
MihaZupan
reviewed
Oct 21, 2024
src/libraries/System.Net.Primitives/tests/UnitTests/CookieExceptionTest.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-System.Net
community-contribution
Indicates that the PR has been added by a community member
new-api-needs-documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements and fixes #95965.
Potentially breaking change if somebody does reflection hacks:
inner
toinnerException
as defined in the approved API scheme.Added APIs