Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cdac] Lazily read global string/object method table pointers #109093

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Oct 22, 2024

When the [c]DAC is created, the string and object method tables may not be loaded and the global pointers set yet. We don't actually need them at creation of SOSDacImpl, so but we were always reading those global pointers and expecting them to be set. Switch reading of the string and object method table pointers to be lazy,

cc @AaronRobinsonMSFT @davidwrighton

Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a minor comment nit, looks good to me.

@elinor-fung elinor-fung merged commit a3815d1 into dotnet:main Oct 22, 2024
145 of 148 checks passed
@elinor-fung elinor-fung deleted the cdac-sosdacimpl-lazy-read branch October 22, 2024 21:13
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants