Build the "in build" crossgen2 into a pack that we can use within the VMR #110676
+106
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in-build host-targeting crossgen2.
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
…st the AOT-in-build logic to handle AOT-ing for the host.
This was referenced Dec 14, 2024
…ary and it breaks the new crossgen2 host package
This was referenced Dec 16, 2024
…time is the last repo.
…gen2 tasks in the SDK to discover the target OS from the source-build target RID
This was referenced Dec 18, 2024
Merged
jkoritzinsky
commented
Dec 19, 2024
src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj
Outdated
Show resolved
Hide resolved
ivdiazsa
reviewed
Dec 19, 2024
src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Crossgen2.props
Outdated
Show resolved
Hide resolved
…lishing to publish packages as packages.
ViktorHofer
reviewed
Dec 30, 2024
ViktorHofer
reviewed
Jan 3, 2025
ViktorHofer
reviewed
Jan 3, 2025
ViktorHofer
reviewed
Jan 7, 2025
src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Jan 9, 2025
This was referenced Jan 9, 2025
ViktorHofer
approved these changes
Jan 10, 2025
|
/ba-g stopped hearing from agent ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the same reasons that we need an "in build" crossgen2 in dotnet/runtime, we need one in the VMR for cross-builds of downstream repos (like aspnetcore).
Opening as draft until I can get enough pieces together to validate the end-to-end experience. This will need changes in aspnetcore, windowsdesktop, sdk, and the orchestration for dotnet/runtime (to put the host crossgen2 package in a place where it won't accidentally get off the machine or cause conflicts in asset selection).
Contributes to dotnet/source-build#3793