Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow collection expressions for 'System.Collections.ObjectModel' collection types #111093

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Allow collection expressions for 'System.Collections.ObjectModel' collection types #111093

wants to merge 12 commits into from
+87 −0

Conversation

AlexRadch
Copy link
Contributor

Close #110161

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 5, 2025
@AlexRadch
Code review
33826df 
Enhance ReadOnlyCollection with documentation and updates

The `EditorBrowsable` attribute is replaced with a `SuppressMessage` attribute to clarify the intended usage of these methods.

Additionally, the condition for checking if input values are empty is updated from `values.Length <= 0` to `values.IsEmpty` for improved readability and performance.
@AlexRadch
Remove unused namespace from ReadOnlyCollection.cs
88183ec 
Eliminated the `using System.ComponentModel;` directive, reducing dependencies and potentially simplifying the code structure.
This was referenced Jan 6, 2025
Open
Open
@AlexRadch
Remove suppression attributes from collection methods
b1860b1 
The `CreateCollection<T>` method in the `ReadOnlyCollection` class had its suppression attribute removed, addressing a style warning related to collection initialization while maintaining its functionality.

Similarly, the `CreateSet<T>` method in the `ReadOnlySet` class also had its suppression attribute removed, preserving its original functionality.
@RikkiGibson RikkiGibson mentioned this pull request Jan 7, 2025
Open
This was referenced Jan 7, 2025
Open
Open
Open
Open
@AlexRadch
Marked CreateCollection and CreateSet methods in ReadOnlyCollection w…
e3aa02c 
…ith the `[EditorBrowsable(EditorBrowsableState.Never)]` attribute to hide them from IntelliSense.
eiriktsarpalis
eiriktsarpalis approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@build-analysis build-analysis bot mentioned this pull request Jan 8, 2025
Open
3 tasks
@AlexRadch
Refactor ReadOnlyCollection and ReadOnlySet APIs
8f98349 
Updated method names in ReadOnlyCollection and ReadOnlySet from CreateCollection and CreateSet to Create for clarity and consistency.

Removed the CreateSet method from ReadOnlyCollection to streamline functionality.
Adjusted documentation comments for improved clarity.

Updated CollectionBuilder attributes to reflect the new method names, ensuring proper linkage for collection creation.
@AlexRadch
Updated the CollectionBuilder attribute to reference ReadOnlySet …
ae5a8e4 
…instead of `ReadOnlyCollection`, reflecting a change in the collection type used in the `ReadOnlySet` class.
@AlexRadch
Code Style
884b7b0
@AlexRadch
Rename methods in ReadOnlyCollection and ReadOnlySet
822639b 
Updated `ReadOnlyCollection` to rename `Create` to `CreateCollection` and introduced `CreateSet` for creating `ReadOnlySet` instances from spans. Adjusted `CollectionBuilder` attributes accordingly and removed the static `ReadOnlySet` class, integrating its functionality into the main class. Updated the `ReadOnlyCollection` partial class in `System.Runtime.cs` to maintain API consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mphelt mphelt mphelt left review comments

@Sergio0694 Sergio0694 Sergio0694 left review comments

@RikkiGibson RikkiGibson RikkiGibson left review comments

@huoyaoyuan huoyaoyuan huoyaoyuan left review comments

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

@stephentoub stephentoub stephentoub left review comments

Assignees
No one assigned
Labels
area-System.Collections community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: allow collection expressions for 'System.Collections.ObjectModel' collection types
7 participants
@AlexRadch @stephentoub @eiriktsarpalis @huoyaoyuan @RikkiGibson @Sergio0694 @mphelt