Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Move profile consistency checks to after loop opts #111285

Merged
merged 14 commits into from
Jan 21, 2025
Merged

JIT: Move profile consistency checks to after loop opts #111285

merged 14 commits into from
Jan 21, 2025

Conversation

amanasifkhalid
Copy link
Member

Part of #107749.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 10, 2025
@amanasifkhalid amanasifkhalid mentioned this pull request Jan 10, 2025
Open
40 tasks
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

This was referenced Jan 11, 2025
Open
Open
@amanasifkhalid
Copy link
Member Author

/azp run runtime-coreclr libraries-jitstress, runtime-coreclr libraries-pgo

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@amanasifkhalid amanasifkhalid changed the title JIT: Move profile consistency checks to after loop recognition JIT: Move profile consistency checks to after loop opts Jan 15, 2025
@amanasifkhalid
Copy link
Member Author

/azp run runtime-coreclr libraries-jitstress, runtime-coreclr libraries-pgo

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

This was referenced Jan 15, 2025
Open
Open
@amanasifkhalid amanasifkhalid marked this pull request as ready for review January 16, 2025 02:05
@amanasifkhalid
Copy link
Member Author

cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Diffs. libraries-pgo and libraries-jitstress runs from the previous build didn't hit any profile-related asserts. Thanks!

@amanasifkhalid
Copy link
Member Author

Updated diffs.

@amanasifkhalid
Copy link
Member Author

/azp run runtime-coreclr libraries-pgo

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@amanasifkhalid
Copy link
Member Author

libraries-pgo failures are #111347 and #111345.

@amanasifkhalid amanasifkhalid merged commit ccc9c52 into dotnet:main Jan 21, 2025
106 of 116 checks passed
@amanasifkhalid amanasifkhalid deleted the profile-checks-loop-finding branch January 21, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@amanasifkhalid amanasifkhalid

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amanasifkhalid @AndyAyersMS