[release/9.0-staging] Fix UNC paths #111499
Open
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
If the input file was a network path then the raw path returned by GetFinalPathByHandle may return a UNC path. If so, and if the original path wasn't a UNC path, and the original path doesn't need normalization, we want to use the original path.
Co-authored-by: Elinor Fung <[email protected]>
Co-authored-by: Elinor Fung <[email protected]>
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
Open
3 tasks
jeffschwMSFT
approved these changes
Jan 16, 2025
jeffschwMSFT
added
the
Servicing-consider
elinor-fung
approved these changes
Jan 21, 2025
jeffschwMSFT
added
Servicing-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #110033 to release/9.0-staging
/cc @agocke
Customer Impact
This change causes apps which are launched from network shares ("UNC paths" aka \server-name) to have their location shown as extended UNC paths ("\?\UNC\server-name"). This is a regression both because the paths are different from what they were before, but also because some APIs will not accept UNC server paths. This manifests as a breaking change in .NET 9.
Regression
Regression from .NET 8 to .NET 9.
Testing
Tested manually. Unfortunately we do not have a way to test network shares in our CI system.
Risk
Low risk. The change is targeted to one API and only to paths which have extended UNC paths.