Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete all constructors for Rfc2898DeriveBytes #111678

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Obsolete all constructors for Rfc2898DeriveBytes #111678

merged 4 commits into from
Jan 23, 2025
+32 −17

Conversation

vcsjones
Copy link
Member

Closes #97221

@vcsjones vcsjones added area-System.Security breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. labels Jan 21, 2025
@vcsjones vcsjones added this to the 10.0.0 milestone Jan 21, 2025
@vcsjones vcsjones self-assigned this Jan 21, 2025
@vcsjones vcsjones requested a review from jeffhandley as a code owner January 21, 2025 20:52
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Jan 21, 2025
This was referenced Jan 21, 2025
Open
Open
@vcsjones @stephentoub
Update Obsoletions.cs
9b714a8 
Co-authored-by: Stephen Toub <[email protected]>
@vcsjones vcsjones merged commit 6ad67d1 into dotnet:main Jan 23, 2025
83 of 85 checks passed
@vcsjones vcsjones deleted the obsolete-rfc2898-ctors branch January 23, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@jeffhandley jeffhandley Awaiting requested review from jeffhandley jeffhandley is a code owner

Assignees

@vcsjones vcsjones

Labels
area-System.Security breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Obsolete all Rfc2898DeriveBytes constructors
2 participants
@vcsjones @stephentoub