Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Replace fgMoveHotJumps with 3-opt utility #112016

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+141 −231
Open

JIT: Replace fgMoveHotJumps with 3-opt utility #112016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e13c6ce
Remove fgMoveHotJumps
amanasifkhalid Jan 30, 2025
d32aab1
Revert "Remove fgMoveHotJumps"
amanasifkhalid Feb 6, 2025
ddf8a72
Merge branch 'main' into remove-fgMoveHotJumps
amanasifkhalid Feb 6, 2025
a90c994
Add ThreeOptLayout::CompactHotJumps
amanasifkhalid Feb 6, 2025
420c470
Remove fgMoveHotJumps
amanasifkhalid Feb 6, 2025
cfd4a89
Don't break up call-finally pairs
amanasifkhalid Feb 6, 2025
6dc6078
Merge from main
amanasifkhalid Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/coreclr/jit/compiler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6369,24 +6369,23 @@ class Compiler
#endif // DEBUG

weight_t GetCost(BasicBlock* block, BasicBlock* next);
weight_t GetPartitionCostDelta(unsigned s1Start, unsigned s2Start, unsigned s3Start, unsigned s3End, unsigned s4End);
weight_t GetPartitionCostDelta(unsigned s2Start, unsigned s3Start, unsigned s3End, unsigned s4End);
void SwapPartitions(unsigned s1Start, unsigned s2Start, unsigned s3Start, unsigned s3End, unsigned s4End);

void ConsiderEdge(FlowEdge* edge);
template <bool addToQueue = true>
bool ConsiderEdge(FlowEdge* edge);
void AddNonFallthroughSuccs(unsigned blockPos);
void AddNonFallthroughPreds(unsigned blockPos);
bool RunGreedyThreeOptPass(unsigned startPos, unsigned endPos);

bool CompactHotJumps();
bool RunThreeOpt();

public:
ThreeOptLayout(Compiler* comp);
void Run();
};

template <bool hasEH>
void fgMoveHotJumps();

bool fgFuncletsAreCold();

PhaseStatus fgDetermineFirstColdBlock();
Expand Down
Loading
Loading