-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] Add support for LDAPTLS_CACERTDIR \ TrustedCertificateDirectory #112530
[release/8.0-staging] Add support for LDAPTLS_CACERTDIR \ TrustedCertificateDirectory #112530
Conversation
Note regarding the
|
1 similar comment
Note regarding the
|
Tagging subscribers to this area: @dotnet/area-system-directoryservices, @jay98014 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.
Files not reviewed (5)
- src/libraries/Common/tests/System/DirectoryServices/LDAP.Configuration.xml: Language not supported
- src/libraries/System.DirectoryServices.Protocols/src/Resources/Strings.resx: Language not supported
- src/libraries/System.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/ldap/LdapConnection.cs: Evaluated as low risk
- src/libraries/Common/src/Interop/Interop.Ldap.cs: Evaluated as low risk
- src/libraries/System.DirectoryServices.Protocols/ref/System.DirectoryServices.Protocols.cs: Evaluated as low risk
@ericstj can you commit this please; I don't have permission. |
You do - you just need all the checks to pass. Seems like |
be6cf76
into
dotnet:release/8.0-staging
Backport of #111877 to release/8.0-staging
Fixes #104260 for v8.0.x
Backport for v9: #112531
/cc @steveharter @JasonDebug
Customer Impact
Adds two new members to System.DirectoryServices.Protocols.LdapSessionOptions to forward to LDAP APIs on Linux\OSX that help with server certificate validation. On Windows, server certificate validation is supported by setting a callback on
LdapSessionOptions.VerifyServerCertificates()
, but that is not supported on Linux\OSX.Regression
Testing
Several months ago, we provided a package with the proposed fix which was validated by the support engineer and customer requesting this feature. Once it was added to v10, the validation was done again. Also, local validation on Linux Ubuntu was done and verification tests were added.
Automated tests here are not supported with current infrastructure as it requires LDAP server support. Currently this must be manually tested.
Risk
Low - although we normally don't add new APIs in a servicing release, it is safer here since this assembly does not ship inbox with .NET so risk is low for versioning issues.