Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for external assembly probe mechanism #113007

Merged
merged 4 commits into from
Mar 3, 2025

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Feb 28, 2025

  • Only try to convert to a loaded layout by file mapping for images that are files
  • Add test that uses corerun with external assembly probe

Contributes to #112706

@Copilot Copilot bot review requested due to automatic review settings February 28, 2025 06:49
Copy link
Contributor

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds a new test to verify the external assembly probe mechanism by checking that the TRUSTED_PLATFORM_ASSEMBLIES property is empty.

  • Adds a new test in ExternalAssemblyProbe.cs that asserts the runtime does not rely on the TPA mechanism.
  • Skips the test on Mono due to unimplemented functionality in the host-runtime contract.

Reviewed Changes

File Description
src/tests/Loader/ExternalAssemblyProbe/ExternalAssemblyProbe.cs New test file that checks the empty state of TRUSTED_PLATFORM_ASSEMBLIES

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

@elinor-fung elinor-fung marked this pull request as ready for review February 28, 2025 22:28
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@elinor-fung
Copy link
Member Author

/ba-g Failure is #113025

@elinor-fung elinor-fung merged commit 1d44636 into dotnet:main Mar 3, 2025
97 of 100 checks passed
@elinor-fung elinor-fung deleted the externalProbe-test branch March 3, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants