Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RISC-V] PerfScore #113011

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[RISC-V] PerfScore #113011

wants to merge 3 commits into from

Conversation

tomeksowi
Copy link
Contributor

@tomeksowi tomeksowi commented Feb 28, 2025

Based on the SiFive U74 core (VisionFive 2). Instruction characteristics in the spec are often implied or lacking but it's something to start with.

Part of #84834, cc @dotnet/samsung

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 28, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 28, 2025
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@risc-vv
Copy link

risc-vv commented Feb 28, 2025

RISC-V Release-CLR-VF2: 9464 / 9540 (99.20%)
=======================
      passed: 9464
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9646
 TOTAL tests: 9646
   REAL time: 2h 6min 15s 669ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: 26c8da05626bde31c217ec444d57bc73d9b47969
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: perf-score
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9464 / 9540 (99.20%)
=======================
      passed: 9464
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9646
 TOTAL tests: 9646
   REAL time: 2h 46min 10s 529ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: 26c8da05626bde31c217ec444d57bc73d9b47969
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: perf-score
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 638451 / 661414 (96.53%)
=======================
      passed: 638451
      failed: 312
     skipped: 1579
      killed: 22651
------------------------
  TOTAL libs: 258
 TOTAL tests: 662993
   REAL time: 2h 26min 43s 574ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 26c8da05626bde31c217ec444d57bc73d9b47969
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: perf-score
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-VF2: 483327 / 511708 (94.45%)
=======================
      passed: 483327
      failed: 155
     skipped: 1478
      killed: 28226
------------------------
  TOTAL libs: 258
 TOTAL tests: 513186
   REAL time: 2h 50min 4s 58ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 26c8da05626bde31c217ec444d57bc73d9b47969
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: perf-score
CONFIG: Release
LIB_CONFIG: Release

Comment on lines +174 to +178
case MajorOpcode::System:
{
code_t funct3 = (code >> 12) & 0b111;
return (funct3 != 0); // CSR read/writes
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugfix, was missing from #110390

Comment on lines +148 to +155
// clang-format off
// inst[4:2] 000, 001, 010, 011, 100, 101, 110, 111 (>32Bit)
/* inst[6:5] */
/* 00 */ Load, LoadFp, Custom0, MiscMem, OpImm, Auipc, OpImm32, Encoding48Bit1,
/* 01 */ Store, StoreFp, Custom1, Amo, Op, Lui, Op32, Encoding64Bit,
/* 11 */ MAdd, MSub, NmSub, NmAdd, OpFp, OpV, Custom2Rv128, Encoding48Bit2,
/* 11 */ Branch, Jalr, Reserved, Jal, System, OpVe, Custom3Rv128, Encoding80Bit,
// clang-format on
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format suspended for easier vetting against the spec.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format suspended for easier vetting against the spec.

This link could be part of the code comment for future readers. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ISA is still expanding, I didn't include a link in case it e.g. moves between files. I put the title in enum comment so it can be ctrl+f'ed.

@risc-vv
Copy link

risc-vv commented Feb 28, 2025

RISC-V Release-CLR-VF2: 9464 / 9540 (99.20%)
=======================
      passed: 9464
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9646
 TOTAL tests: 9646
   REAL time: 2h 5min 47s 927ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: d91ec23c848dad5d022dc0851f2c1ee555481ba2
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: perf-score
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9464 / 9540 (99.20%)
=======================
      passed: 9464
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9646
 TOTAL tests: 9646
   REAL time: 2h 46min 10s 428ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: d91ec23c848dad5d022dc0851f2c1ee555481ba2
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: perf-score
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-VF2: 627350 / 660806 (94.94%)
=======================
      passed: 627350
      failed: 160
     skipped: 1479
      killed: 33296
------------------------
  TOTAL libs: 258
 TOTAL tests: 662285
   REAL time: 2h 22min 21s 211ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: d91ec23c848dad5d022dc0851f2c1ee555481ba2
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: perf-score
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 626158 / 654510 (95.67%)
=======================
      passed: 626158
      failed: 316
     skipped: 1451
      killed: 28036
------------------------
  TOTAL libs: 258
 TOTAL tests: 655961
   REAL time: 2h 26min 32s 778ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: d91ec23c848dad5d022dc0851f2c1ee555481ba2
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: perf-score
CONFIG: Release
LIB_CONFIG: Release

@am11 am11 added the arch-riscv Related to the RISC-V architecture label Feb 28, 2025
@tomeksowi tomeksowi marked this pull request as ready for review March 3, 2025 09:41
@risc-vv
Copy link

risc-vv commented Mar 3, 2025

RISC-V Release-CLR-VF2: 9464 / 9540 (99.20%)
=======================
      passed: 9464
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9646
 TOTAL tests: 9646
   REAL time: 2h 6min 37s 227ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

Build information and commands

GIT: b820f93216ab37ee7c79b5efdb0fd2fd1c3adb3e
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: perf-score
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-CLR-QEMU: 9464 / 9540 (99.20%)
=======================
      passed: 9464
      failed: 59
     skipped: 106
      killed: 17
------------------------
  TOTAL libs: 9646
 TOTAL tests: 9646
   REAL time: 2h 45min 52s 330ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

Build information and commands

GIT: b820f93216ab37ee7c79b5efdb0fd2fd1c3adb3e
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: perf-score
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-QEMU: 635674 / 668114 (95.14%)
=======================
      passed: 635674
      failed: 314
     skipped: 1579
      killed: 32126
------------------------
  TOTAL libs: 258
 TOTAL tests: 669693
   REAL time: 2h 22min 57s 163ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: b820f93216ab37ee7c79b5efdb0fd2fd1c3adb3e
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: perf-score
CONFIG: Release
LIB_CONFIG: Release

RISC-V Release-FX-VF2: 624418 / 652231 (95.74%)
=======================
      passed: 624418
      failed: 153
     skipped: 1413
      killed: 27660
------------------------
  TOTAL libs: 258
 TOTAL tests: 653644
   REAL time: 2h 42min 7s 703ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: b820f93216ab37ee7c79b5efdb0fd2fd1c3adb3e
CI: a8426a46d8575dfcb3b5fec0d7d0b7a7c118d690
REPO: tomeksowi/runtime
BRANCH: perf-score
CONFIG: Release
LIB_CONFIG: Release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants