Add more known Regex patterns to increase test coverage. #1617
Conversation
| [InlineData("a\u0300", true)] // \u0300 is in {Mn} | ||
| [InlineData("\u0300b", false)] // \u0300 is in {Mn} | ||
| [InlineData("https://foo.com:443/bar/17/groups/0ad1/providers/Network/public/4e-ip?version=16", false)] | ||
| [InlineData("[email protected]", false)] |
There was a problem hiding this comment.
Nit: I see this came from some ancient BCL blog (at least) but I suggest to replace with a [email protected] address that definitely doesn't belong to anyone.
There was a problem hiding this comment.
I see this came from some ancient BCL blog
It's actually in the docs:
https://docs.microsoft.com/en-us/dotnet/standard/base-types/how-to-verify-that-strings-are-in-valid-email-format#compile-the-code
I just put all of the docs samples into our tests, basically verbatim.
There was a problem hiding this comment.
And I just copied it from the above test.
I can anonymize all the emails (ex. [email protected]) in this file, if you two think it is necessary.
There was a problem hiding this comment.
Funny enough, proseware.com redirects me to https://www.microsoft.com/en-us/. So I think it is safe. 😉
ghost
locked as resolved and limited conversation to collaborators
Adding a few real-world Regex patterns I found.