Use RuntimeHelpers.GetHashCode instead of obj.GetHashCode #31756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit tests will commit in a few minutes |
ahsonkhan
reviewed
Feb 4, 2020
...aries/System.Text.Json/src/System/Text/Json/Serialization/ReferenceEqualsEqualityComparer.cs
Show resolved
Hide resolved
jozkee
reviewed
Feb 5, 2020
src/libraries/System.Text.Json/tests/Serialization/ReferenceHandlingTests.Serialize.cs
Outdated
Show resolved
Hide resolved
jozkee
approved these changes
Feb 5, 2020
There was a problem hiding this comment.
Other than https://github.com/dotnet/runtime/pull/31756/files#r375016781 suggestion; it looks good to me.
jozkee
requested changes
Feb 5, 2020
...aries/System.Text.Json/src/System/Text/Json/Serialization/ReferenceEqualsEqualityComparer.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/tests/Serialization/ReferenceHandlingTests.Serialize.cs
Outdated
Show resolved
Hide resolved
jozkee
approved these changes
Feb 5, 2020
jozkee
reviewed
Feb 6, 2020
src/libraries/Common/src/System/Collections/Generic/ReferenceEqualityComparer.cs
Outdated
Show resolved
Hide resolved
…ion/ReferenceEqualsEqualityComparer.cs Co-Authored-By: David Cantu <[email protected]>
This was referenced Feb 6, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2128
Please review
Thank you in advance