Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish the other part of the GCTotalPhysicalMemory config implementation #36152

Merged
merged 3 commits into from
May 9, 2020
Merged

Finish the other part of the GCTotalPhysicalMemory config implementation #36152

merged 3 commits into from
May 9, 2020

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented May 8, 2020

No description provided.

Maoni0 and others added 3 commits May 5, 2020 22:32
@Maoni0
Finish the other part of the GCTotalPhysicalMemory config implementation
7b9915e 
The total physical memory specified by the GCTotalPhysicalMemory config
needs to communicated over to the VM side for memory load calculation.
Otherwise inside GC we are using the correct physical memory specified,
but when we ask for the memory load it's still based on the total available
memory.
@jkotas
Delete unnecessary delay-loading of kernel32.dll
bc272f1
@jkotas
Avoid mutable restricted memory limit inside OS PAL
cce81b6
@ghost
Copy link

ghost commented May 8, 2020

Tagging subscribers to this area: @Maoni0
Notify danmosemsft if you want to be subscribed.

@jkotas jkotas mentioned this pull request May 8, 2020
Closed
Maoni0
Maoni0 approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this too; thanks @jkotas! since you feel strongly enough to write up an impl, let's go with this.

@Maoni0 Maoni0 changed the title (Alternative) Finish the other part of the GCTotalPhysicalMemory config implementation Finish the other part of the GCTotalPhysicalMemory config implementation May 9, 2020
@jkotas jkotas merged commit caf6923 into dotnet:master May 9, 2020
@jkotas jkotas deleted the phymem_config branch May 16, 2020 17:11
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Maoni0 Maoni0 Maoni0 approved these changes

Assignees
No one assigned
Labels
area-GC-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkotas @Maoni0 @Dotnet-GitSync-Bot