Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obsolete Encoding.UTF7 property and UTF7Encoding ctors #37535
Obsolete Encoding.UTF7 property and UTF7Encoding ctors #37535
Changes from all commits
0057f56
b832840
93f90b3
cb96b40
660dd15
db7fa60
e8acb23
d77c36b
d4179d1
908b106
2dc4656
9d6811c
092119d
e9245bf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What custom provider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you call
Encoding.RegisterProvider
, you can override the return value ofEncoding.GetEncoding("utf-7")
,Encoding.GetEncoding("utf-8")
, and any other encoding instance. If you register a custom provider for UTF-7, we never query theAppContext
switch because this switch statement never get hit.Registering a custom provider doesn't change the return value of the built-in accelerators (like
Encoding.UTF7
orEncoding.UTF8
) since they're hardcoded to always use the built-in implementation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. It's the "re-enabled" lingo that confuses me. There's no way for someone to get at our built-in Encoding to "re-enable" it via Encoding.RegisterProvider, is there? They've have to implement one from scratch, no?