Fix VeryLargeAmountOfEnumsToSerialize test #37710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Jun 10, 2020
src/libraries/System.Text.Json/tests/Serialization/EnumConverterTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 10, 2020
src/libraries/System.Text.Json/tests/Serialization/EnumConverterTests.cs
Show resolved
Hide resolved
steveharter
reviewed
Jun 10, 2020
| Parallel.For(0, 8, i => JsonSerializer.Serialize((MyEnum)(46 + i), options)); | ||
|
|
||
| // Write the remaining enum values. We should not store any more values in | ||
| // the cache. If we do, we may throw OutOfMemoryException on some machines. |
There was a problem hiding this comment.
Perhaps clarify a bit that the OutOfMemoryException would be thrown if we didn't have a cap on the dictionary.
// Write the remaining enum values. The cache is capped to avoid OutOfMemoryException due
// to having too many cached items.
There was a problem hiding this comment.
Will update the comment in #37720 (to avoid CI reset).
steveharter
reviewed
Jun 10, 2020
|
|
||
| // Write the remaining enum values. We should not store any more values in | ||
| // the cache. If we do, we may throw OutOfMemoryException on some machines. | ||
| for (int i = 54; i <= MaxValue; i++) |
There was a problem hiding this comment.
How long does this test take?
There was a problem hiding this comment.
It takes ~6.75s on my machine (which would be ~20% of total test time if it were not outer-loop).
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37471. Follow up for #36726.