-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase BufferPtrSendOperation test coverage #38935
increase BufferPtrSendOperation test coverage #38935
Conversation
…a usage of sync method that uses BufferPtrSendOperation internally
Tagging subscribers to this area: @dotnet/ncl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Did you confirm this hits that code path?
Yes, but only by inspecting the code, not actually running it (I've run in on Windows, not on Linux). |
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
The CI failure is not related to this change (#38998), merging |
@stephentoub wrote in #38762 (comment)
recently I've spent some time debugging
CopyToAsync_AllDataCopied
(#38747) and I think that it's a good candidate for extending to test the sync path as well