Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Overloads for Add(Json/Systemd/Simple)Console #39725

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Add Overloads for Add(Json/Systemd/Simple)Console #39725

merged 2 commits into from
Jul 21, 2020

Conversation

maryamariyan
Copy link
Member

@maryamariyan maryamariyan commented Jul 21, 2020 •
edited
Loading

Fixes #39631

  • API approved

@maryamariyan maryamariyan added this to the 5.0.0 milestone Jul 21, 2020
@maryamariyan maryamariyan requested a review from tarekgh July 21, 2020 17:18
@maryamariyan maryamariyan self-assigned this Jul 21, 2020
@ghost
Copy link

ghost commented Jul 21, 2020

Tagging subscribers to this area: @maryamariyan
Notify danmosemsft if you want to be subscribed.

@Dotnet-GitSync-Bot
Copy link
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@maryamariyan maryamariyan changed the title Add Overloads for AddSystemdConsole and AddJsonConsole Add Overloads for Add(Systemd/Systemd/Simple)Console Jul 21, 2020
@maryamariyan maryamariyan changed the title Add Overloads for Add(Systemd/Systemd/Simple)Console Add Overloads for Add(Json/Systemd/Simple)Console Jul 21, 2020
@tarekgh tarekgh requested review from davidfowl and eerhardt July 21, 2020 20:29
@maryamariyan
Copy link
Member Author

Seems github didn't update the build badges, but both builds are green:
https://dev.azure.com/dnceng/public/_build/results?buildId=739791&view=results
https://dev.azure.com/dnceng/public/_build/results?buildId=739795&view=results

@maryamariyan maryamariyan merged commit e87fbd1 into dotnet:master Jul 21, 2020
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@maryamariyan @Jacksondr5
Add Overloads for Add(Json/Systemd/Simple)Console (dotnet#39725)
a8a3c79
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@eerhardt eerhardt eerhardt approved these changes

@tarekgh tarekgh tarekgh approved these changes

Assignees

@maryamariyan maryamariyan

Labels
area-Extensions-Logging new-api-needs-documentation
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Add new overloads for AddSystemdConsole and AddJsonConsole not needing configure argument
5 participants
@maryamariyan @Dotnet-GitSync-Bot @davidfowl @eerhardt @tarekgh