Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn pauseonstart test off for Windows #39789

Merged

Conversation

josalem
Copy link
Contributor

@josalem josalem commented Jul 22, 2020

There is an intermittent timeout only on Windows for the PauseOnStart tests. Work towards a solution is being tracked in #38847. This turns the test off for Windows CI legs.

CC @tommcdon

@josalem josalem added the disabled-test The test is disabled in source code against the issue label Jul 22, 2020
@josalem josalem added this to the 5.0.0 milestone Jul 22, 2020
@josalem josalem requested review from jashook and BruceForstall July 22, 2020 16:59
@josalem josalem self-assigned this Jul 22, 2020
@ghost
Copy link

ghost commented Jul 22, 2020

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@ghost
Copy link

ghost commented Jul 22, 2020

Hello @josalem!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@josalem
Copy link
Contributor Author

josalem commented Jul 23, 2020

The automerge didn't happen because GH never updated to see the AzDO job complete successfully. I have a fix for the issue in #39807. Should we still merge this while that is being reviewed?

@BruceForstall
Copy link
Member

have a fix for the issue in #39807. Should we still merge this while that is being reviewed?

Yes.

@josalem
Copy link
Contributor Author

josalem commented Jul 23, 2020

Manually merging due to GH not seeing successful CI.

@josalem josalem merged commit 56c882e into dotnet:master Jul 23, 2020
@josalem josalem deleted the dev/josalem/disable-pauseonstart-win-x86 branch July 23, 2020 17:46
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Diagnostics-coreclr disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants