HTTP2 Perf: Optimize decoding of HPack static table #40745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephentoub
reviewed
Aug 13, 2020
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Stream.cs
Outdated
Show resolved
Hide resolved
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JamesNK
reviewed
Aug 13, 2020
| } | ||
| else if (index <= LastHPackStatusPseudoHeaderId) | ||
| { | ||
| int statusCode = HPackStaticStatusCodeTable[index - FirstHPackStatusPseudoHeaderId]; |
There was a problem hiding this comment.
nit: Replace the array lookup with a switch?
There was a problem hiding this comment.
That might be slightly better but I'm not sure it matters in practice.
There was a problem hiding this comment.
A switch does seem a little better here to me as well, but not a big deal.
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Stream.cs
Show resolved
Hide resolved
|
@dotnet/ncl can I get a review? |
|
@scalablecory Can you do a quick review? It's pretty straightforward. |
stephentoub
approved these changes
Sep 14, 2020
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Stream.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Stream.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Stream.cs
Outdated
Show resolved
Hide resolved
| } | ||
| else if (index <= LastHPackStatusPseudoHeaderId) | ||
| { | ||
| int statusCode = HPackStaticStatusCodeTable[index - FirstHPackStatusPseudoHeaderId]; |
There was a problem hiding this comment.
A switch does seem a little better here to me as well, but not a big deal.
geoffkizer
force-pushed
the
http2staticheaders
branch
from
98133a3 to
00de34b
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1505
Currently, when we decode a header ID from the static table, we convert it to the ASCII header name/value and then parse this again in order to determine if it's a known header.
Instead, optimize this by avoiding the conversion to ASCII and simply map it directly to a known header descriptor, or handle it directly if it's a pseudo header (i.e. status code).
@JamesNK @dotnet/ncl