Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Mark System.Data.Common APIs as unsupported on Browser #41263

Closed
wants to merge 6 commits into from
Closed

[wasm] Mark System.Data.Common APIs as unsupported on Browser #41263

wants to merge 6 commits into from

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Aug 24, 2020

Contributes to #41087

browser "M:System.Data.DataSet.GetObjectData(System.Runtime.Serialization.SerializationInfo,System.Runtime.Serialization.StreamingContext)",System.Data,DataSet,"GetObjectData(SerializationInfo, StreamingContext)",2
browser "M:System.Data.DataSet.#ctor(System.Runtime.Serialization.SerializationInfo,System.Runtime.Serialization.StreamingContext,System.Boolean)",System.Data,DataSet,".ctor(SerializationInfo, StreamingContext, Boolean)",3
browser "M:System.Data.SqlTypes.SqlChars.System#Runtime#Serialization#ISerializable#GetObjectData(System.Runtime.Serialization.SerializationInfo,System.Runtime.Serialization.StreamingContext)",System.Data.SqlTypes,SqlChars,"System.Runtime.Serialization.ISerializable.GetObjectData(SerializationInfo, StreamingContext)",0
browser "M:System.Data.SqlTypes.SqlBytes.System#Runtime#Serialization#ISerializable#GetObjectData(System.Runtime.Serialization.SerializationInfo,System.Runtime.Serialization.StreamingContext)",System.Data.SqlTypes,SqlBytes,"System.Runtime.Serialization.ISerializable.GetObjectData(SerializationInfo, StreamingContext)",0
obsolete M:System.Data.Common.DataAdapter.CloneInternals,System.Data.Common,DataAdapter,CloneInternals(),1
browser M:System.Data.Common.DbDataAdapter.System#ICloneable#Clone,System.Data.Common,DbDataAdapter,System.ICloneable.Clone(),2

@ghost
Copy link

ghost commented Aug 24, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

@MaximLipnin MaximLipnin mentioned this pull request Aug 24, 2020
Closed
71 tasks
@mdh1418 mdh1418 changed the title Mdhwang/system data common unsupported [wasm] Mark System.Data.Common APIs as unsupported on Browser Aug 25, 2020
jkotas
jkotas reviewed Aug 25, 2020
View reviewed changes
src/libraries/System.Data.Common/src/System/Data/Common/DbDataAdapter.cs
@@ -231,6 +232,7 @@ protected virtual void ClearBatch()
throw ADP.NotSupported();
}

[UnsupportedOSPlatform("browser")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What makes this unsupported on browser?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it looks like a false-positive. Thanks!

jkotas
jkotas reviewed Aug 25, 2020
View reviewed changes
src/libraries/System.Data.Common/src/System/Data/DataSet.cs
@@ -227,6 +228,7 @@ protected DataSet(SerializationInfo info, StreamingContext context) : this(info,
{
}

[UnsupportedOSPlatform("browser")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is same as #41085. It does not make sense to be marking serialization infrastructure as unsupported on browser.

@ghost
Copy link

ghost commented Sep 5, 2020

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

@mdh1418
Copy link
Member Author

mdh1418 commented Sep 8, 2020

Closing this PR as Clone is likely a false-positive from obsolete API, CloneInternals is obsolete, and the others are related to serialization infrastructure.

@mdh1418 mdh1418 closed this Sep 8, 2020
@mdh1418 mdh1418 deleted the mdhwang/system_data_common_unsupported branch September 8, 2020 15:58
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas left review comments

@lewing lewing Awaiting requested review from lewing

@steveisok steveisok Awaiting requested review from steveisok

@MaximLipnin MaximLipnin Awaiting requested review from MaximLipnin

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-System.Data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdh1418 @jkotas @danmoseley