Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Mark System.IO.MemoryMappedFiles APIs unsupported on browser #41971

Closed
wants to merge 1 commit into from
Closed

[wasm] Mark System.IO.MemoryMappedFiles APIs unsupported on browser #41971

wants to merge 1 commit into from

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Sep 8, 2020

Contributes to #41087

"M:System.IO.MemoryMappedFiles.MemoryMappedFile.OpenExisting(System.String,System.IO.MemoryMappedFiles.MemoryMappedFileRights)",System.IO.MemoryMappedFiles,MemoryMappedFile,"OpenExisting(String, MemoryMappedFileRights)",2
"M:System.IO.MemoryMappedFiles.MemoryMappedFile.CreateNew(System.String,System.Int64)",System.IO.MemoryMappedFiles,MemoryMappedFile,"CreateNew(String, Int64)",2
"M:System.IO.MemoryMappedFiles.MemoryMappedFile.CreateFromFile(System.String,System.IO.FileMode,System.String,System.Int64)",System.IO.MemoryMappedFiles,MemoryMappedFile,"CreateFromFile(String, FileMode, String, Int64)",2
M:System.IO.MemoryMappedFiles.MemoryMappedFile.CreateFromFile(System.String),System.IO.MemoryMappedFiles,MemoryMappedFile,CreateFromFile(String),2
M:System.IO.MemoryMappedFiles.MemoryMappedFile.OpenExisting(System.String),System.IO.MemoryMappedFiles,MemoryMappedFile,OpenExisting(String),2
"M:System.IO.MemoryMappedFiles.MemoryMappedFile.CreateOrOpen(System.String,System.Int64)",System.IO.MemoryMappedFiles,MemoryMappedFile,"CreateOrOpen(String, Int64)",2
"M:System.IO.MemoryMappedFiles.MemoryMappedFile.CreateNew(System.String,System.Int64,System.IO.MemoryMappedFiles.MemoryMappedFileAccess,System.IO.MemoryMappedFiles.MemoryMappedFileOptions,System.IO.HandleInheritability)",System.IO.MemoryMappedFiles,MemoryMappedFile,"CreateNew(String, Int64, MemoryMappedFileAccess, MemoryMappedFileOptions, HandleInheritability)",1
"M:System.IO.MemoryMappedFiles.MemoryMappedFile.CreateFromFile(System.IO.FileStream,System.String,System.Int64,System.IO.MemoryMappedFiles.MemoryMappedFileAccess,System.IO.HandleInheritability,System.Boolean)",System.IO.MemoryMappedFiles,MemoryMappedFile,"CreateFromFile(FileStream, String, Int64, MemoryMappedFileAccess, HandleInheritability, Boolean)",1
"M:System.IO.MemoryMappedFiles.MemoryMappedFile.CreateFromFile(System.String,System.IO.FileMode,System.String,System.Int64,System.IO.MemoryMappedFiles.MemoryMappedFileAccess)",System.IO.MemoryMappedFiles,MemoryMappedFile,"CreateFromFile(String, FileMode, String, Int64, MemoryMappedFileAccess)",1
"M:System.IO.MemoryMappedFiles.MemoryMappedFile.CreateFromFile(System.String,System.IO.FileMode,System.String)",System.IO.MemoryMappedFiles,MemoryMappedFile,"CreateFromFile(String, FileMode, String)",2
"M:System.IO.MemoryMappedFiles.MemoryMappedFile.CreateFromFile(System.String,System.IO.FileMode)",System.IO.MemoryMappedFiles,MemoryMappedFile,"CreateFromFile(String, FileMode)",2
"M:System.IO.MemoryMappedFiles.MemoryMappedFile.CreateOrOpen(System.String,System.Int64,System.IO.MemoryMappedFiles.MemoryMappedFileAccess)",System.IO.MemoryMappedFiles,MemoryMappedFile,"CreateOrOpen(String, Int64, MemoryMappedFileAccess)",2
"M:System.IO.MemoryMappedFiles.MemoryMappedFile.OpenExisting(System.String,System.IO.MemoryMappedFiles.MemoryMappedFileRights,System.IO.HandleInheritability)",System.IO.MemoryMappedFiles,MemoryMappedFile,"OpenExisting(String, MemoryMappedFileRights, HandleInheritability)",1
"M:System.IO.MemoryMappedFiles.MemoryMappedFile.CreateNew(System.String,System.Int64,System.IO.MemoryMappedFiles.MemoryMappedFileAccess)",System.IO.MemoryMappedFiles,MemoryMappedFile,"CreateNew(String, Int64, MemoryMappedFileAccess)",2
"M:System.IO.MemoryMappedFiles.MemoryMappedFile.CreateOrOpen(System.String,System.Int64,System.IO.MemoryMappedFiles.MemoryMappedFileAccess,System.IO.MemoryMappedFiles.MemoryMappedFileOptions,System.IO.HandleInheritability)",System.IO.MemoryMappedFiles,MemoryMappedFile,"CreateOrOpen(String, Int64, MemoryMappedFileAccess, MemoryMappedFileOptions, HandleInheritability)",1

CreateOrOpen OpenExisting are windows supported only.

@mdh1418 mdh1418 added arch-wasm WebAssembly architecture area-System.IO labels Sep 8, 2020
@MaximLipnin MaximLipnin mentioned this pull request Sep 8, 2020
Closed
71 tasks
@mdh1418
Copy link
Member Author

mdh1418 commented Sep 9, 2020

On second glance, I think these are false positives based on running ValidArgumentCombinationsWithPath_ModeCreateNew and ValidArgumentCombinations

@mdh1418 mdh1418 closed this Sep 9, 2020
@mdh1418 mdh1418 deleted the mdhwang/system_io_memorymappedfiles_unsupported branch September 11, 2020 15:43
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MaximLipnin MaximLipnin MaximLipnin approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@steveisok steveisok Awaiting requested review from steveisok

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-System.IO
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdh1418 @MaximLipnin