[release/5.0-rc2] Backport Browser Unsupported Attribute Changes Properly #42071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
mdh1418
force-pushed
the
mdhwang/backport_unsupported_browser_attributes_properly
branch
from
eaafb86 to
42e4239
Compare
mdh1418
requested review from
akoeplinger,
EgorBo and
vargaz
as code owners
leecow
added
Servicing-approved
Anipik
changed the title
|
@mdh1418 could you please work on resolving the conflict |
…net#41094) * [wasm] System.ComponentModel enable platform attributes * [wasm] Mark ExtendedProtectionPolicyTypeConverter.ConvertTo as unsupported * [wasm] Mark System.ComponentModel.TypeDescriptor.CreateInstance as unsupported * [wasm] Mark System.ComponentModel.TypeDescriptionProvider.CreateInstance as unsupported * [wasm] Mark System.ComponentModel.LicenseManager.CreateWithContext as unsupported * [wasm] Mark System.ComponentModel.MaskedTextProvider.Clone as unsupported Co-authored-by: Mitchell Hwang <[email protected]>
* [wasm] Mark System.Console APIs as unsupported on Browser * System.Console remove unsupported attribute from Console.Clear() * System.Console mark SetIn as unsupported on Browser * System.Console move UnsupportedOSPlatform attributes down to the accessor Co-authored-by: Mitchell Hwang <[email protected]>
…tnet#41271) Co-authored-by: Mitchell Hwang <[email protected]>
…#41694) Co-authored-by: Mitchell Hwang <[email protected]>
…net#41683) * [wasm] System.IO.Compression.Brotli enable platform attributes * Mark System.IO.Compression.Brotli unsupported at assembly level Co-authored-by: Mitchell Hwang <[email protected]>
…er (dotnet#41682) * [wasm] System.IO.FileSystem.Watcher enable platform attributes * Mark System.IO.FileSystem.Watcher unsupported at assembly level Co-authored-by: Mitchell Hwang <[email protected]>
…otnet#41700) * [wasm] System.IO.IsolatedStorage enable platform attributes * Mark System.IO.IsolatedStorage Unsupported at assembly level Co-authored-by: Mitchell Hwang <[email protected]>
…t#41891) * System.Threading.ThreadPool enable platform attributes * Mark System.Threading.ThreadPool APIs unsupported on browser * System.Threading.ThreadPool Add Unsupported attribute to other ThreadPool files * Remove Unsupported attributes from BindHandle * Add windows Supported Attribute to BindHandle Co-authored-by: Mitchell Hwang <[email protected]>
… on Browser (dotnet#41963) * Mark System.Net.WebSockets.ClientWebSocketOptions APIs as unsupported on Browser * Add the attributes to non-browser version of ClientWebSocketOptions class to avoid build error * Add using * Include platform attributes
…otnet#41985) Co-authored-by: Mitchell Hwang <[email protected]>
mdh1418
force-pushed
the
mdhwang/backport_unsupported_browser_attributes_properly
branch
from
42e4239 to
d31a893
Compare
marek-safar
approved these changes
Sep 11, 2020
mdh1418
deleted the
mdhwang/backport_unsupported_browser_attributes_properly
branch
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
N/A
Master PR
#41094 #41184 #41271 #41694 #41683 #41682 #41700 #40924 #41891 #41963 #41985
Description
The Platform Compatibility Analyzer can be used to identify APIs that are problematic on other specific platforms or deprecated. With the attribute
UnsupportedOSPlatformAttribute("browser"), numerous APIs that are not supported on Browser WASM are marked for the platform compatibility analyzer to pick up.Customer Impact
Without this fix, customers will not be warned against using certain unsupported APIs on Browser WASM.
Risk
Low.