Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Process.WaitForExitAsync wait for redirected output reads #42585

Conversation

eiriktsarpalis
Copy link
Member

Addresses an issue where Process.WaitForExitAsync doesn't wait for background redirected output reads, a behaviour which diverges from the sync method equivalent. Fixes #42556.

cc @adamsitnik @stephentoub

Addresses an issue where Process.WaitForExitAsync
doesn't wait for background redirected output reads,
a behaviour which diverges from the sync method
equivalent. Fixes dotnet#42556.
@ghost
Copy link

ghost commented Sep 22, 2020

Tagging subscribers to this area: @eiriktsarpalis, @jeffhandley
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the cited boxing issue is addressed. Thanks.

@eiriktsarpalis eiriktsarpalis merged commit 1ea8eb1 into dotnet:master Sep 28, 2020
@eiriktsarpalis eiriktsarpalis deleted the fix-process-waitforexitasync-output-eof branch September 28, 2020 16:22
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process.WaitForExitAsync doesn't wait for the reditected output to be read
2 participants