Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glob include files based on project extension (VS) #46702

Merged
merged 4 commits into from
Jan 8, 2021
Merged

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Jan 7, 2021

Wasn't reported but something that I just noticed while scanning code. Extracting into the root Directory.Build.targets, as this is the behavior that we want to see throughout the repo.

@ghost
Copy link

ghost commented Jan 7, 2021

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Wasn't reported but something that I just noticed while scanning code.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries

Milestone: -

@ViktorHofer ViktorHofer requested a review from Anipik January 7, 2021 20:51
Directory.Build.targets Outdated Show resolved Hide resolved
@safern
Copy link
Member

safern commented Jan 8, 2021

Failure is: #32030

@safern safern merged commit e36948f into master Jan 8, 2021
@safern safern deleted the ViktorHofer-patch-1 branch January 8, 2021 01:20
Copy link
Contributor

@Anipik Anipik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ghost ghost locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants