Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ConcurrentDictionary.Comparer property #47787

Merged
merged 4 commits into from
Feb 3, 2021
Merged

Added ConcurrentDictionary.Comparer property #47787

merged 4 commits into from
Feb 3, 2021

Conversation

I-SER-I
Copy link
Contributor

@I-SER-I I-SER-I commented Feb 2, 2021

fix #31350

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Feb 2, 2021

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

fix #31350

Author: I-SER-I
Assignees: -
Labels:

area-System.Collections, new-api-needs-documentation
Milestone: -

@dnfadmin
Copy link

dnfadmin commented Feb 2, 2021 •
edited
Loading

CLA assistant check
All CLA requirements met.

@I-SER-I
Copy link
Contributor Author

I-SER-I commented Feb 3, 2021 •
edited
Loading

In video said that it is a copy of the Dictionary. It no works cause interface IInternalStringEqualityComparer placed in CoreLIb - internal. What to do?

@I-SER-I I-SER-I marked this pull request as draft February 3, 2021 02:24
@I-SER-I I-SER-I marked this pull request as ready for review February 3, 2021 04:22
@I-SER-I I-SER-I requested a review from stephentoub February 3, 2021 04:22
stephentoub
stephentoub reviewed Feb 3, 2021
View reviewed changes
...ries/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentDictionary.cs
@@ -1051,6 +1051,8 @@ private bool TryAddInternal(TKey key, int? nullableHashcode, TValue value, bool
private static void ThrowKeyNotFoundException(TKey key) =>
throw new KeyNotFoundException(SR.Format(SR.Arg_KeyNotFoundWithKey, key.ToString()));

public IEqualityComparer<TKey> Comparer => _comparer ?? _defaultComparer;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please add an xml comment to help seed the documentation for the new member.

stephentoub
stephentoub approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eiriktsarpalis eiriktsarpalis merged commit 9f921f4 into dotnet:master Feb 3, 2021
@stephentoub
Copy link
Member

@eiriktsarpalis, the member still needed XML docs added. Do you want to add that?

@eiriktsarpalis eiriktsarpalis mentioned this pull request Feb 3, 2021
Merged
@eiriktsarpalis
Copy link
Member

My bad, created a new PR adding docs.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis left review comments

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-System.Collections new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ConcurrentDictionary.Comparer property
4 participants
@I-SER-I @dnfadmin @stephentoub @eiriktsarpalis