Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support single file in DependencyModel #48790

Merged
merged 2 commits into from
Feb 26, 2021
Merged

Conversation

eerhardt
Copy link
Member

When used in a single file application, Assembly.CodeBase will throw an exception. Check for this situation by checking if Assembly.Location is empty before trying to probe next to the assembly.

Fix #47527

When used in a single file application, Assembly.CodeBase will throw an exception. Check for this situation by checking if Assembly.Location is empty before trying to probe next to the assembly.

Fix dotnet#47527
@ghost
Copy link

ghost commented Feb 26, 2021

Tagging subscribers to this area: @eerhardt
See info in area-owners.md if you want to be subscribed.

Issue Details

When used in a single file application, Assembly.CodeBase will throw an exception. Check for this situation by checking if Assembly.Location is empty before trying to probe next to the assembly.

Fix #47527

Author: eerhardt
Assignees: -
Labels:

area-DependencyModel

Milestone: -

@eerhardt
Copy link
Member Author

EventSource failure in runtime (Libraries Test Run release coreclr windows x64 Debug) is #48798

@eerhardt eerhardt merged commit d0616f8 into dotnet:master Feb 26, 2021
@eerhardt eerhardt deleted the Fix47527 branch February 26, 2021 15:17
@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DependencyContextLoader tries to use Assembly.CodeBase - error in .NET 5
3 participants