Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppresses the trimmer warning on TypeAnalysis ctor #48823

Merged
merged 42 commits into from
Mar 8, 2021
Merged
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
54516c7
eh fix
LakshanF Oct 29, 2020
dbe9ca4
Merge remote-tracking branch 'upstream/master'
LakshanF Oct 29, 2020
70e04d7
Merge remote-tracking branch 'upstream/master'
LakshanF Jan 1, 2021
f4fc3f8
Merge remote-tracking branch 'upstream/master'
LakshanF Jan 6, 2021
ee6401d
Merge remote-tracking branch 'upstream/master'
LakshanF Jan 7, 2021
e87f26c
Merge remote-tracking branch 'upstream/master'
LakshanF Feb 9, 2021
af6bcb0
Merge remote-tracking branch 'upstream/master'
LakshanF Feb 10, 2021
9cc84c0
Merge remote-tracking branch 'upstream/master'
LakshanF Feb 10, 2021
2f7bc29
Merge remote-tracking branch 'upstream/master'
LakshanF Feb 11, 2021
42eadd3
test change that inadvertently got checked in earlier
LakshanF Feb 11, 2021
d4d9e31
Merge remote-tracking branch 'upstream/master'
LakshanF Feb 12, 2021
7317d3c
Merge remote-tracking branch 'upstream/master'
LakshanF Feb 17, 2021
f04fb8d
Merge remote-tracking branch 'upstream/master'
LakshanF Feb 22, 2021
3427371
Merge remote-tracking branch 'upstream/master'
LakshanF Feb 23, 2021
5cf8134
Merge branch 'master' of https://github.com/LakshanF/runtime
LakshanF Feb 23, 2021
584e0e3
Merge remote-tracking branch 'upstream/master'
LakshanF Feb 24, 2021
715dcbd
Merge branch 'master' of https://github.com/LakshanF/runtime
LakshanF Feb 24, 2021
8dab23e
Merge remote-tracking branch 'upstream/master'
LakshanF Feb 25, 2021
56fcb12
Merge branch 'master' of https://github.com/LakshanF/runtime
LakshanF Feb 25, 2021
7679b91
Merge remote-tracking branch 'upstream/master'
LakshanF Feb 26, 2021
1fdfdbf
Merge remote-tracking branch 'upstream/master'
LakshanF Feb 26, 2021
f50c6f9
Merge branch 'master' of https://github.com/LakshanF/runtime
LakshanF Feb 26, 2021
db9be82
Suppresses the trimmer warning on TypeAnalysis ctor
LakshanF Feb 26, 2021
b623513
Incorporating FB
LakshanF Feb 26, 2021
045e38d
Update src/libraries/System.Diagnostics.DiagnosticSource/src/System/D…
LakshanF Mar 1, 2021
a9dda65
Update src/libraries/System.Diagnostics.DiagnosticSource/src/System/D…
LakshanF Mar 1, 2021
4ccd2ae
Update src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tr…
LakshanF Mar 1, 2021
ea460c3
Fix DynamicDependency as per PR feedback
LakshanF Mar 1, 2021
31667cf
Merge branch 'EventSrcWrnFix2' of https://github.com/LakshanF/runtime…
LakshanF Mar 1, 2021
3e56d85
an earlier change got reverted
LakshanF Mar 1, 2021
aa2a21d
fixed proj file netcore app condition check
LakshanF Mar 1, 2021
3d61a44
fixed NETCORE_ENGINEERING_TELEMETRY build failures
LakshanF Mar 1, 2021
5775e1a
fixeing another NETCORE_ENGINEERING_TELEMETRY build failures
LakshanF Mar 1, 2021
f1d3a1b
Adding RequiresUnreferencedCode to TypeAnalysis ctor instead of suppr…
LakshanF Mar 2, 2021
589ee3f
PR FB and suppressing warnings for safe calls
LakshanF Mar 3, 2021
bb4a18d
propagated the warning all the way up
LakshanF Mar 3, 2021
024c8d6
CI build break fix for one file
LakshanF Mar 3, 2021
7dd337f
Merge branch 'main' into EventSrcWrnFix2
LakshanF Mar 4, 2021
6d51f12
excluding NativeRTEventSrc from being build in a project
LakshanF Mar 4, 2021
bfd3bc3
Merge branch 'EventSrcWrnFix2' of https://github.com/LakshanF/runtime…
LakshanF Mar 4, 2021
0540809
Missed couple of supppressions on NativeRTEventSrc
LakshanF Mar 4, 2021
f0ca444
build break fixes
LakshanF Mar 4, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CI build break fix for one file
LakshanF committed Mar 3, 2021
commit 024c8d654c624b28aea4df69ce4bf8c8d1de4fed
Original file line number Diff line number Diff line change
@@ -13,6 +13,9 @@ namespace System.Diagnostics.Tracing
// To look at CoreCLR implementation of these events, refer to NativeRuntimeEventSource.PortableThreadPool.CoreCLR.cs.
internal sealed partial class NativeRuntimeEventSource : EventSource
{
#if !ES_BUILD_STANDALONE
private const string EventSourceSuppressMessage = "Parameters to this method are primitive and are trimmer safe";
#endif
// This value does not seem to be used, leaving it as zero for now. It may be useful for a scenario that may involve
// multiple instances of the runtime within the same process, but then it seems unlikely that both instances' thread
// pools would be in moderate use.
@@ -135,6 +138,10 @@ public unsafe void ThreadPoolWorkerThreadAdjustmentSample(
WriteEventCore(54, 2, data);
}

#if !ES_BUILD_STANDALONE
[UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:UnrecognizedReflectionPattern",
Justification = EventSourceSuppressMessage)]
#endif
[Event(55, Level = EventLevel.Informational, Message = Messages.WorkerThreadAdjustmentAdjustment, Task = Tasks.ThreadPoolWorkerThreadAdjustment, Opcode = Opcodes.Adjustment, Version = 0, Keywords = Keywords.ThreadingKeyword)]
public unsafe void ThreadPoolWorkerThreadAdjustmentAdjustment(
double AverageThroughput,
@@ -162,6 +169,10 @@ public unsafe void ThreadPoolWorkerThreadAdjustmentAdjustment(
WriteEventCore(55, 4, data);
}

#if !ES_BUILD_STANDALONE
[UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:UnrecognizedReflectionPattern",
Justification = EventSourceSuppressMessage)]
#endif
[Event(56, Level = EventLevel.Verbose, Message = Messages.WorkerThreadAdjustmentStats, Task = Tasks.ThreadPoolWorkerThreadAdjustment, Opcode = Opcodes.Stats, Version = 0, Keywords = Keywords.ThreadingKeyword)]
public unsafe void ThreadPoolWorkerThreadAdjustmentStats(
double Duration,
@@ -217,6 +228,10 @@ public unsafe void ThreadPoolWorkerThreadAdjustmentStats(
WriteEventCore(56, 11, data);
}

#if !ES_BUILD_STANDALONE
[UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:UnrecognizedReflectionPattern",
Justification = EventSourceSuppressMessage)]
#endif
[Event(63, Level = EventLevel.Verbose, Message = Messages.IOEnqueue, Task = Tasks.ThreadPool, Opcode = Opcodes.IOEnqueue, Version = 0, Keywords = Keywords.ThreadingKeyword | Keywords.ThreadTransferKeyword)]
private unsafe void ThreadPoolIOEnqueue(
IntPtr NativeOverlapped,
@@ -243,6 +258,10 @@ private unsafe void ThreadPoolIOEnqueue(

// TODO: This event is fired for minor compat with CoreCLR in this case. Consider removing this method and use
// FrameworkEventSource's thread transfer send/receive events instead at callers.
#if !ES_BUILD_STANDALONE
[UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:UnrecognizedReflectionPattern",
Justification = EventSourceSuppressMessage)]
#endif
[NonEvent]
[MethodImpl(MethodImplOptions.NoInlining)]
public void ThreadPoolIOEnqueue(RegisteredWaitHandle registeredWaitHandle)
@@ -253,6 +272,10 @@ public void ThreadPoolIOEnqueue(RegisteredWaitHandle registeredWaitHandle)
}
}

#if !ES_BUILD_STANDALONE
[UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:UnrecognizedReflectionPattern",
Justification = EventSourceSuppressMessage)]
#endif
[Event(64, Level = EventLevel.Verbose, Message = Messages.IO, Task = Tasks.ThreadPool, Opcode = Opcodes.IODequeue, Version = 0, Keywords = Keywords.ThreadingKeyword | Keywords.ThreadTransferKeyword)]
private unsafe void ThreadPoolIODequeue(
IntPtr NativeOverlapped,