Code

WebSocket Compression#49304

Code

Merged

CarnaViire merged 47 commits intodotnet:maindotnet/runtime:mainfrom zlatanov:websocket-deflate-v2zlatanov/runtime:websocket-deflate-v2Copy head branch name to clipboardApr 28, 2021

+2,309-187

Commits

Commits on Apr 26, 2021

• Prototyped how deflate/inflate should be plugged in.

  zlatanov

  committed
  705c171

  Copy full SHA for 705c171

• Replaced WebSocketReceiveResultGetter abstraction for the receive with a generic method which can be inlined by the jit.

  zlatanov

  committed
  740798c

  Copy full SHA for 740798c

• Moved ZLibNative and ZLibNative.ZStream to Common so they can be used in other projects as well.

  zlatanov

  committed
  72a34fd

  Copy full SHA for 72a34fd

• Added compression related implementation.

  zlatanov

  committed
  5128c9f

  Copy full SHA for 5128c9f

• Added api changes and implementation to ClientWebSocket to light up deflate compression.

  zlatanov

  committed
  2825973

  Copy full SHA for 2825973

• Added tests and fixed a few deflate bugs.

  zlatanov

  committed
  67a5d72

  Copy full SHA for 67a5d72

• Forgot to dispose inflater & deflater.

  zlatanov

  committed
  9cb024e

  Copy full SHA for 9cb024e

• Addressing pr feedback.

  zlatanov

  committed
  92cf8f4

  Copy full SHA for 92cf8f4

• Moved deflate state into deflater.

  zlatanov

  committed
  4045305

  Copy full SHA for 4045305

• Moved inflater buffer into the inflater.

  zlatanov

  committed
  862e163

  Copy full SHA for 862e163

• Using Math.Clamp instead of Math.Min/Max.

  zlatanov

  committed
  92520b6

  Copy full SHA for 92520b6

• Releasing deflater buffer as soon as we're done using it.

  zlatanov

  committed
  4d024fa

  Copy full SHA for 4d024fa

• Using 2 constructors in ManagedWebSocket to avoid allocations for WebSocketCreationOptions in the existing API.

  zlatanov

  committed
  b8bdfae

  Copy full SHA for b8bdfae

• Added missing assert.

  zlatanov

  committed
  7e8d3c4

  Copy full SHA for 7e8d3c4

• Removed unnecessary comments that visual studio inserted from resx files.

  zlatanov

  committed
  3869367

  Copy full SHA for 3869367

• Better buffer handling in inflater.

  zlatanov

  committed
  b7f58b1

  Copy full SHA for b7f58b1

• Renaming clientBufferLength to userBufferLength.

  zlatanov

  committed
  c6c3326

  Copy full SHA for c6c3326

• Fixed an issue in inflater / deflater where with context takeover, the sliding window was reset with every message.

  zlatanov

  committed
  7ec3151

  Copy full SHA for 7ec3151

• Revert removal of BOM.

  zlatanov

  committed
  271c9cd

  Copy full SHA for 271c9cd

• PR feedback for ClientWebSocket.

  zlatanov

  committed
  61c7e5b

  Copy full SHA for 61c7e5b

• PR feedback for WebSocket.

  zlatanov

  committed
  4fa65f4

  Copy full SHA for 4fa65f4

• Prefer Length over IsEmpty for spans.

  zlatanov

  committed
  9031be3

  Copy full SHA for 9031be3

• Fixed wrong check.

  zlatanov

  committed
  4e70073

  Copy full SHA for 4e70073

• New API that allows disabling compression per message basis and renaming DeflateOptions properties to DangerousDeflateOptions. Also addressed some PR feedback and added new tests.

  zlatanov

  committed
  b7743ef

  Copy full SHA for b7743ef

• Added comment explaining why GetReceiveResult<TResult> will not result in boxing of a struct.

  zlatanov

  committed
  49d00eb

  Copy full SHA for 49d00eb

• Exposed DeflateReset and InflateReset methods from zlib.

  zlatanov

  committed
  58a3338

  Copy full SHA for 58a3338

• Pooling zlib streams.

  zlatanov

  committed
  56fd0ef

  Copy full SHA for 56fd0ef

• Moved min/max deflate window bits consants to WebSocketValidate so they can be used in System.Net.WebSockets.Client.

  zlatanov

  committed
  fdf41d6

  Copy full SHA for fdf41d6

• Testing negotiation of deflate options with reflection.

  zlatanov

  committed
  4fd18f6

  Copy full SHA for 4fd18f6

• Removed the default value for messageFlags parameter.

  zlatanov

  committed
  29c539a

  Copy full SHA for 29c539a

• pr feedback

  zlatanov

  committed
  0739640

  Copy full SHA for 0739640

• Removed cache capacity limit for deflate streams. Now the cache is only controlled by the inactivity timeout for the streams.

  zlatanov

  committed
  224f7ab

  Copy full SHA for 224f7ab

• Created a test with active issue to track a failing case for the deflate compression.

  zlatanov

  committed
  4a7feb4

  Copy full SHA for 4a7feb4

• Disabled client websocket deflate tests for browser platform.

  zlatanov

  committed
  222c782

  Copy full SHA for 222c782

• Created tests for ZLibStream pooling.

  zlatanov

  committed
  0b09b5b

  Copy full SHA for 0b09b5b

• Reusing constants in deflate options.

  zlatanov

  committed
  99869bf

  Copy full SHA for 99869bf

• Fixing tests for browser environment.

  zlatanov

  committed
  c46a0f3

  Copy full SHA for c46a0f3

• Added Block flush code for zlib, because it's needed for websockets.

  zlatanov

  committed
  3ec748d

  Copy full SHA for 3ec748d

• Bug fixes after running Autobahn WebSocket Testsuite.

  zlatanov

  committed
  fb45f2c

  Copy full SHA for fb45f2c

• Addressing PR feedback.

  zlatanov

  committed
  00283e8

  Copy full SHA for 00283e8

• Fixed a test.

  zlatanov

  committed
  5a0e435

  Copy full SHA for 5a0e435

• Addressing flakiness of a couple of tests.

  zlatanov

  committed
  935969a

  Copy full SHA for 935969a

• Disallowing the usage of different compression options for continuations.

  zlatanov

  committed
  437b7e7

  Copy full SHA for 437b7e7

• Removed [ActiveIssue] from websocket deflate tests. Created a new test that replicates Autobahn Test Case 13.3.1 which causes "invalid distance too far" zlib error.

  zlatanov

  committed
  5edadd9

  Copy full SHA for 5edadd9

Commits on Apr 28, 2021

• Addressing PR feedback.

  zlatanov

  committed
  f6a4b32

  Copy full SHA for f6a4b32

• Removed custom deflate pool.

  zlatanov

  committed
  f0f09f3

  Copy full SHA for f0f09f3

• Added missing dispose when creating deflater.

  zlatanov

  committed
  ea049ea

  Copy full SHA for ea049ea