EventSource Feature switch type fix #49432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iagnostics/DiagnosticSourceEventSource.cs Co-authored-by: Eric Erhardt <[email protected]>
…iagnostics/DiagnosticSourceEventSource.cs Co-authored-by: Eric Erhardt <[email protected]>
…acing/EventSource.cs Co-authored-by: Eric Erhardt <[email protected]>
…into EventSrcWrnFix2
…essing the warning to get FB, not fully fixed
…into EventSrcWrnFix2
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
vitek-karas
approved these changes
Mar 10, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
NativeRuntimeEventSourcewas rooted incorrectly in ILLinkTrim.xml and fixed that to allow the trimmer to trim correctly later when the feature switch,EventSourceSupport, is set to false. This is related to issue #43657Also a small cleanup in
System.Private.CoreLib.Generators.csprojthat I missed in an earlier PR