Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address the remaining comments from Date/TimeOnly PR #51261

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Address the remaining comments from Date/TimeOnly PR #51261

merged 1 commit into from
Apr 15, 2021

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Apr 14, 2021

No description provided.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@tarekgh
Copy link
Member Author

tarekgh commented Apr 14, 2021

@stephentoub this PR to address the remaining comments you left in #50980. Thanks for reviewing.

@tarekgh tarekgh self-assigned this Apr 14, 2021
@tarekgh tarekgh added this to the 6.0.0 milestone Apr 14, 2021
stephentoub
stephentoub approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@stephentoub stephentoub merged commit 3af1861 into dotnet:main Apr 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

@tarekgh tarekgh

Labels
area-System.DateTime
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tarekgh @stephentoub @jeffhandley