-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add runtimeconfig.json support to AppleAppBuilder, reenable affected tests #53172
Add runtimeconfig.json support to AppleAppBuilder, reenable affected tests #53172
Conversation
Tagging subscribers to this area: @tarekgh, @krwq, @eiriktsarpalis, @layomia Issue DetailsIt's quite unexpected to me that overriding methods through
|
The android failures are a known issue dotnet/xharness#597 The wasm failure is also know #50965 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The linker tests are impacted somehow with the path to the runtimeconfig task.
I'll look at the linker tests... or just condition the task/target to only run on mobile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Native bits LGTM, thanks!
@@ -239,6 +239,8 @@ mono_droid_runtime_init (const char* executable, int managed_argc, char* managed | |||
arg->kind = 0; | |||
arg->runtimeconfig.name.path = file_path; | |||
monovm_runtimeconfig_initialize (arg, cleanup_runtime_config, file_path); | |||
} else { | |||
free (file_path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me. Thanks for adding runtimeconfig.json support to AppleAppBuilder.
Fixes #50573
Fixes #51394
It's quite unexpected to me that overriding methods through
runtimeconfig.template.json
doesn't work on WASM/iOS/Android. Some of the properties can be specified with both MSBuild properties and the JSON config file. The MSBuild properties take precedence over the user specified JSON file. Since the new SDKs specify defaults for the MSBuild properties the defaults always override the JSON config mechanism.