Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build clr/libs dependencies of test build locally #53696

Merged
merged 7 commits into from
Jun 5, 2021
Merged

Build clr/libs dependencies of test build locally #53696

merged 7 commits into from
Jun 5, 2021

Conversation

davidwrighton
Copy link
Member

  • Stop relying on the actual product build for these
  • Should reduce long pole of running coreclr tests by removing need to wait for coreclr/libraries product builds to complete before test build can begin
  • Evidence shows that the native lib build can also be elided, but that requires more complex build work

@davidwrighton
Build clr/libs dependencies of test build locally
041b8bf 
- Stop relying on the actual product build for these
- Should reduce long pole of running coreclr tests by removing need to wait for coreclr/libraries product builds to complete before test build can begin
- Evidence shows that the native lib build can also be elided, but that requires more complex build work
@ghost
Copy link

ghost commented Jun 3, 2021

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Stop relying on the actual product build for these
  • Should reduce long pole of running coreclr tests by removing need to wait for coreclr/libraries product builds to complete before test build can begin
  • Evidence shows that the native lib build can also be elided, but that requires more complex build work
Author: davidwrighton
Assignees: -
Labels:

area-Infrastructure-coreclr
Milestone: -

@hoyosjs
Copy link
Member

hoyosjs commented Jun 4, 2021

This looks good now. This could easily cut 30 mins of every PR. Thanks!

@davidwrighton davidwrighton requested review from trylek and hoyosjs June 4, 2021 00:29
@davidwrighton davidwrighton marked this pull request as ready for review June 4, 2021 01:02
@davidwrighton davidwrighton merged commit d2a42d7 into dotnet:main Jun 5, 2021
@hoyosjs hoyosjs mentioned this pull request Jun 8, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 5, 2021
@davidwrighton davidwrighton deleted the faster_pr_runs branch April 13, 2023 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hoyosjs hoyosjs hoyosjs approved these changes

@trylek trylek Awaiting requested review from trylek

Assignees
No one assigned
Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidwrighton @hoyosjs