[release/6.0-preview6] Fix the slot calculation for multiple services #54503
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
… was not correct for more than 5 services. - Added tests to verify the slot calculation and service resolution.
|
Tagging subscribers to this area: @eerhardt, @maryamariyan Issue DetailsBackport of #54462 to release/6.0-preview6 /cc @davidfowl Customer ImpactTestingRisk
|
|
In the same vein, it would be nice to update https://github.com/dotnet/core/blob/main/release-notes/6.0/known-issues.md to mention this issue so that folks don't spend too much time chasing this nasty bug 😄 |
|
@danmoseley can you unblock this one? It was approved |
|
Failure is #50270 ... any theory @davidfowl ? I couldn't find it. |
|
Hmm, I apparently don't have power to merge though. @ericstj do I need admin rights? |
Nothing to do with this PR 😄 . Re-running. |
|
Yes certainly, the issue is old. I was just wondering whether you had a theory about the cause - you see I looked in the past and added notes in there. Perhaps you're familiar with that code. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #54462 to release/6.0-preview6
/cc @davidfowl
Customer Impact
By default customers using DI in .NET 5 could be broken in very bad ways if any dependency in their application (including library dependencies) inject an
IEnumerable<T>with more than 5 services into their constructor. They'll end up with the wrong set of dependencies. We've already had 2 customers report this on the new .NET 5 preview. This happens in development mode only by default since that's when the service validation feature is on.This is a regression in preview5.
Testing
Added explicit tests for this scenario up to 6 services (from 1 to 6). Also added tests that verify the slot calculation (which is an internal detail that caused this to break).
Risk
Low/None.