-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][debugger] Fixing debugger tests errors #54664
Conversation
Errno is not being assigned anymore. DebuggerTests.SetVariableValueTests
Tagging subscribers to this area: @thaystg Issue DetailsErrno is not being assigned anymore. DebuggerTests.SetVariableValueTests
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsErrno is not being assigned anymore in a case like this: intmax_t val = strtoimax ("error", &endptr, 10); This was causing failures in this tests: DebuggerTests.SetVariableValueTests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we pass a char *variableValueEnd
argument to write_value_to_buffer
and also compare endptr != variableValueEnd
to make sure that there are no unconsumed digits at the end of the string?
Are these values coming from something we control, or from user JS?
It's coming from user JS. |
I will add a test trying to pass a value like "123thays" it would process until the third character of the string. I will check if in this case errno is set. |
@lambdageek thanks for the hint! :) |
Errno is not being assigned anymore in a case like this:
intmax_t val = strtoimax ("error", &endptr, 10);
This was causing failures in these tests: DebuggerTests.SetVariableValueTests
Passing icordbg flag as false.