Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The short version of the bug is that the transforms in question did not account for persistent side effects, which could lead to silent bad codegen. Also, the
GTF_EXCEPT
guards were unnecessary for transforms that did not reorder operands.This change leads to one diff in the benchmarks, a regression of 2 bytes, caused by the fact that
gtCanSwapOrder
does not understand that we can swap when both trees haveGTF_GLOB_REF
set, but no other effects on them:Fixes #55140.
Note: I am aware that
gtCanSwapOrder
is not without its problems as well, but it still seems decidedly better to use it instead of bespoke guards.