Remove legacy light-up code from System.Reflection.Metadata et.al.
#56587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
commented
Jul 29, 2021
...Reflection.Metadata/src/System/Reflection/Internal/MemoryBlocks/StreamMemoryBlockProvider.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 30, 2021
...Reflection.Metadata/src/System/Reflection/Internal/MemoryBlocks/StreamMemoryBlockProvider.cs
Outdated
Show resolved
Hide resolved
|
cc: @tmat |
|
I also replaced the implementation of |
teo-tsirpanis
changed the title
System.Reflection.Metadata.System.Reflection.Metadata et.al.
teo-tsirpanis
force-pushed
the
srm-lightup-remove
branch
from
b2d7001 to
063500b
Compare
krwq
reviewed
Aug 6, 2021
| { | ||
| private static bool IsReadFileAvailable => Path.DirectorySeparatorChar == '\\'; | ||
| private static bool IsWindows => Path.DirectorySeparatorChar == '\\'; |
There was a problem hiding this comment.
RuntimeInformation.IsOSPlatform(OSPlatform.Windows)?
There was a problem hiding this comment.
That also works but I kept using DirectorySeparatorChar because the check is simpler (we compare two characters vs two strings), and RuntimeInformation would require referencing another assembly from S.R.M for just one API (I guess?).
There was a problem hiding this comment.
it's a one time cost, not sure about the implementation detail. either way, treat as optional
tmat
reviewed
Aug 16, 2021
...Reflection.Metadata/src/System/Reflection/Internal/MemoryBlocks/StreamMemoryBlockProvider.cs
Outdated
Show resolved
Hide resolved
teo-tsirpanis
force-pushed
the
srm-lightup-remove
branch
from
f898312 to
4582555
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.Reflection.Metadataused to target frameworks that lacked features like memory-mapped files, theEncoding.GetStringoverload that takes a pointer, and theFileStreamclass. In these cases, it would opportunistically use them through reflection or fall back to other slower paths.Because these old frameworks are no longer targeted and almost all these APIs are now universally available (except the
Stream.Readoverload that takes a span), this PR removes most of this so-called "light-up" code.