Update changed solution files under src/libraries #57483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
requested review from
eiriktsarpalis,
layomia and
steveharter
as code owners
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsCommit 1: Update slngen logic and remove unnecessary P2Ps Invoking slngen has a non-deterministic ordering of some elements in the solution file so I still had to manually revert unnecessary order only changes. Filed microsoft/slngen#251 to investigate. Replaces #56494
|
ViktorHofer
commented
Aug 16, 2021
src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj
Show resolved
Hide resolved
Anipik
reviewed
Aug 17, 2021
akoeplinger
approved these changes
Aug 18, 2021
|
The code generation issues are observable in other PRs as well and I think StephenT is working on fixing them. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1: Update slngen logic and remove unnecessary P2Ps
Commit 2: Update changed soluion files under src/libraries
Invoking slngen has a non-deterministic ordering of some elements in the solution file so I still had to manually revert unnecessary order only changes. Filed microsoft/slngen#251 to investigate.
Replaces #56494