Code

File.*AllText* optimizations#58167

Code

Merged

adamsitnik merged 18 commits intodotnet:maindotnet/runtime:mainfrom adamsitnik:fileOptimizationsadamsitnik/runtime:fileOptimizationsCopy head branch name to clipboardOct 14, 2021

+425-420

Commits

Commits on Aug 26, 2021

• optimize File.*AllText* APIs

  adamsitnik

  committed
  c7dc3a9

  Copy full SHA for c7dc3a9

• remove code duplication

  adamsitnik

  committed
  fe18dbf

  Copy full SHA for fe18dbf

• use expression bodies

  adamsitnik

  committed
  50a3528

  Copy full SHA for 50a3528

Commits on Aug 27, 2021

• ensure there are no trailing zeroes when EOF < preallocationSize on Unix

  adamsitnik

  committed
  9b81560

  Copy full SHA for 9b81560

• ensure that all code paths are covered by tests

  adamsitnik

  committed
  878c4fa

  Copy full SHA for 878c4fa

• fix bug discovered by new tests: when the content is empty, we still need to store the preamble

  adamsitnik

  committed
  328cdaf

  Copy full SHA for 328cdaf

• flush the encoder on last loop iteration

  adamsitnik

  committed
  8da83ee

  Copy full SHA for 8da83ee

• for a single write operation setting preallocationSize has no perf benefit, as it requires additional sys-call(s)

  adamsitnik

  committed
  a992375

  Copy full SHA for a992375

• Apply suggestions from code review

  Show description for eb8f1bf
  

  adamsitnik

  and

  stephentoub

  authored
  eb8f1bf

  Copy full SHA for eb8f1bf

• style consistency

  adamsitnik

  committed
  7eaaa48

  Copy full SHA for 7eaaa48

Commits on Aug 30, 2021

• address code review feedback

  adamsitnik

  committed
  82190c5

  Copy full SHA for 82190c5

• don't write a preamble to non-empty file

  adamsitnik

  committed
  e0dafc5

  Copy full SHA for e0dafc5

Commits on Oct 13, 2021

• Merge remote-tracking branch 'upstream/main' into fileOptimizations

  Show description for 982d1d6
  adamsitnik

  committed
  982d1d6

  Copy full SHA for 982d1d6

• use exact size

  adamsitnik

  committed
  256e5f0

  Copy full SHA for 256e5f0

Commits on Oct 14, 2021

• Merge remote-tracking branch 'upstream/main' into fileOptimizations

  adamsitnik

  committed
  95b474a

  Copy full SHA for 95b474a

• MS_IO_REDIST has been removed

  adamsitnik

  committed
  dbecac2

  Copy full SHA for dbecac2

• Apply suggestions from code review

  Show description for 280009a
  

  adamsitnik

  and

  jozkee

  authored
  280009a

  Copy full SHA for 280009a

• remove redundant file size check that was failing for character devices

  adamsitnik

  committed
  8a67c96

  Copy full SHA for 8a67c96