[release/6.0] [mono/win] Increase stack size (reserve) to 8MB #60561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Fix #57141 in windows build. Set the stack size (reserve) to 8MB, which is usually a default on linux. This way we should get similar behavior on windows.
|
cc @marek-safar |
|
I tested this PR, and it solves the issue; we can compile projects successfully. Thanks! |
lewing
approved these changes
Nov 1, 2021
leecow
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #60265 to release/6.0
/cc @lewing @radekdoulik
Increase the AOT compilers reserve stack size to 8MB to avoid an AOT compilation failure due to insufficient stack space.
Customer Impact
Resolves a potential crash in AOT compilation.
Testing
Manual and Automatic
Risk
Very Low